Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tokio-stream] needs dev-dependency so tests can run #7019

Closed
werdahias opened this issue Dec 6, 2024 · 2 comments · Fixed by #7020
Closed

[tokio-stream] needs dev-dependency so tests can run #7019

werdahias opened this issue Dec 6, 2024 · 2 comments · Fixed by #7020
Labels
A-tokio-stream Area: The tokio-stream crate C-bug Category: This is a bug.

Comments

@werdahias
Copy link

Version
Latest (0.1.16)

When updating tokio-stream to 0.1.16 in Debian I discovered that apparently tokio-stream has a missing dev-dependency on tokio-test.
E.g. tests/stream_collect.rs has use tokio_test::{... . However, the release on crates.io has no dependency on tokio-test, causing the tests to fai. Adding a patch for a -dev-dependency on tokio-test makes all tests pass.

@werdahias werdahias added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Dec 6, 2024
@werdahias
Copy link
Author

I see that it's present in git, so I assume something in the release process went wrong here.

@Darksonn Darksonn added A-tokio-stream Area: The tokio-stream crate and removed A-tokio Area: The main tokio crate labels Dec 6, 2024
@Darksonn
Copy link
Contributor

Darksonn commented Dec 6, 2024

It's because tokio-stream did not specify a version for the tokio-test dependency. This has already been fixed by #6931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-stream Area: The tokio-stream crate C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants