Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event::get should not return an option. #536

Closed
carllerche opened this issue Feb 6, 2017 · 1 comment
Closed

Event::get should not return an option. #536

carllerche opened this issue Feb 6, 2017 · 1 comment

Comments

@carllerche
Copy link
Member

It's an index operation and should panic on invalid index.
@carllerche
Copy link
Member Author

Actually, this probably isn't true. The get fn should return Option and at some point there should be a std::ops that is better suited for the index op: rust-lang/rfcs#997

As of now, indexing will be rare in favor of iterating, so I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carllerche