Format "last woken" time prettily

[hds]

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

Tokio console has nice prettily formatted times when UTF-8 support is turned on.

The times use only a small number of decimal places and are colour coded depending on the multiplier (seconds, milliseconds, etc.).

However, in the Task detail screen in the Waker panel, there is a time for "last woken" which does not have this formatting. It is not color-coded and it generally displays far too many decimal places.

How can the bug be reproduced?

Enter the task detail screen for a task that has been woken at least once. Look at the Waker panel, specifically the "last woken" value.

See screenshot for details and a comparison of the pretty vs. non-pretty times:

Logs, error output, etc

No response

Versions

tokio-console: 0.1.10 (and also the main branch at the time of writing).

Possible solution

Change the formatting of the value for "last woken":

console/tokio-console/src/view/task.rs

Line 208 in 28a27fc

wakeups.push(Span::from(format!(" {:?} ago", since)));

See the value for the "total time" field in the Task panel for an example of how to format the time prettily:

console/tokio-console/src/view/task.rs

Line 183 in 28a27fc

styles.time_units(total, view::DUR_LIST_PRECISION, None),

[devanbenz]

I can take this one on

[hds]

Unassigned @devanbenz, that was a mistake.

[yerke]

Hi @hds. I created #529 to address this. Do you mind taking a look?

[hds]

Hi @hds. I created #529 to address this. Do you mind taking a look?

@yerke Yes,looks good, It might not get merged until Monday though.