You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @postfalk - I think this would be probably easier to discuss on a call but just putting it here while my thoughts are fresh.
I started attempting to implement CuddeBack tests in tests_cameras.py, following the patterns you had laid out for the RidgeTecs, but quickly realized it would be easier to read in the real CuddeLink email file as the example for testing rather than attempting to mock the email & attached image in the tests/examples.py file. That seemed to work fine, but I started looking around some of the other test files (test_handler.py and test_helpers.py, for example), and noticed you were already doing that to test getting the email and saving attached images - so that was a bit confusing (why aren't all tests using tests/examples.py). In some cases, e.g. in test_handler_ridgetec, you're half creating a new mocked email right in the test and half using the mocked ridgetec email defined in examples.py):
Hey @postfalk - I think this would be probably easier to discuss on a call but just putting it here while my thoughts are fresh.
I started attempting to implement CuddeBack tests in
tests_cameras.py
, following the patterns you had laid out for the RidgeTecs, but quickly realized it would be easier to read in the real CuddeLink email file as the example for testing rather than attempting to mock the email & attached image in thetests/examples.py
file. That seemed to work fine, but I started looking around some of the other test files (test_handler.py
andtest_helpers.py
, for example), and noticed you were already doing that to test getting the email and saving attached images - so that was a bit confusing (why aren't all tests usingtests/examples.py
). In some cases, e.g. intest_handler_ridgetec
, you're half creating a new mocked email right in the test and half using the mocked ridgetec email defined inexamples.py
):The text was updated successfully, but these errors were encountered: