From 2ffcf93a75d2f1fd663a11878de5642a46a03660 Mon Sep 17 00:00:00 2001 From: tmcgee123 Date: Tue, 11 Jan 2022 17:41:53 -0600 Subject: [PATCH] test(rewire): remove rewire dep and related code, override process via Object.assign instead --- package.json | 1 - test/index.spec.js | 25 +++++++++++-------------- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/package.json b/package.json index 299fe19..3c2c05b 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,6 @@ "mocha": "^3.2.0", "mocha-runner": "^1.1.1", "npm-run-all": "^4.0.2", - "rewire": "^2.5.1", "sinon": "^1.17.2", "sinon-chai": "^2.8.0" }, diff --git a/test/index.spec.js b/test/index.spec.js index b5b095e..cb03396 100644 --- a/test/index.spec.js +++ b/test/index.spec.js @@ -32,7 +32,6 @@ /* jshint ignore:end */ -var rewire = require('rewire'); var chai = require('chai'); var sinon = require('sinon'); var sinonChai = require('sinon-chai'); @@ -40,7 +39,6 @@ chai.use(sinonChai); var should = chai.should(); var expect = chai.expect; var os = require('os'); -var reporterRewire = rewire('../index.js'); var SpecReporter = require('../index.js')['reporter:spec']; var ansiColors = { @@ -65,24 +63,23 @@ var baseReporterDecorator = function(context) { context.writeCommonMsg = sinon.spy(); context.write = sinon.spy(); }; - +var originalPlatform = ''; describe('SpecReporter', function() { describe('when initializing', function() { describe('and on a windows machine', function() { + after(function(done){ + Object.defineProperty(process, 'platform', { + value: originalPlatform + }); + done(); + }) function createSpecReporter(config) { config = config || {}; - var processMock = { - platform: function() { - return 'win32'; - } - }; - reporterRewire.__set__({ - 'reporter:spec': SpecReporter, - process: { - platform: 'win32' - } + originalPlatform = process.platform; + Object.defineProperty(process, 'platform', { + value: 'win32' }); - return new reporterRewire['reporter:spec'][1](baseReporterDecorator, formatError, config); + return new SpecReporter[1](baseReporterDecorator, formatError, config); } it('SpecReporter should have icons defined appropriately', function() {