Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensionify ServerKeyShare #214

Closed
davegarrett opened this issue Aug 4, 2015 · 3 comments
Closed

Extensionify ServerKeyShare #214

davegarrett opened this issue Aug 4, 2015 · 3 comments

Comments

@davegarrett
Copy link
Contributor

ClientKeyShare was converted from a message into an extension. I suggest doing the same for ServerKeyShare. This would make the two consistent with each-other and work towards issue #184.

@ekr
Copy link
Contributor

ekr commented Sep 22, 2015

Consensus in interim is "let's do it".

@davegarrett davegarrett changed the title Consider extensionifying ServerKeyShare Extensionify ServerKeyShare Sep 23, 2015
@davegarrett
Copy link
Contributor Author

Here's an early WIP:
davegarrett@66d2fb3

The client extension and server message already use the same struct, so just merging them into one general extension is relatively simple and better than two almost identical extensions.

@davegarrett
Copy link
Contributor Author

Ok, PR #268 filed for this. Will probably need some changes, so feedback / drive-by reviews would be appreciated in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants