Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a new ClientRandom for HelloRetryRequest #185

Closed
ekr opened this issue Jun 17, 2015 · 3 comments
Closed

Generate a new ClientRandom for HelloRetryRequest #185

ekr opened this issue Jun 17, 2015 · 3 comments
Labels
discuss-seattle PR Pending

Comments

@ekr
Copy link
Contributor

ekr commented Jun 17, 2015

Suggested by Karthik
@davegarrett
Copy link
Contributor

I created a short PR for this: PR #189

@davegarrett
Copy link
Contributor

I amended the PR to make sure to be clear that the new client random is used and the old is discarded, and that it still ends up in the session hash which still starts from the beginning of the connection with the initial ClientHello. (see also issue #104, which this might be sufficient to resolve)

@davegarrett davegarrett mentioned this issue Sep 26, 2015
Closed
@ekr ekr added the PR Pending label Nov 17, 2015
@davegarrett
Copy link
Contributor

@ekr: Please close this too. (this is the issue for PR #189)

@ekr ekr closed this as completed Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss-seattle PR Pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekr @davegarrett