Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: allow all simulation methods to work for all channels #54

Open
tlambert03 opened this issue Jun 17, 2024 · 0 comments
Open

todo: allow all simulation methods to work for all channels #54

tlambert03 opened this issue Jun 17, 2024 · 0 comments

Comments

@tlambert03
Copy link
Owner

currently only Simulation.run() returns all channels, via this code:

if channels is None:
channels = tuple(range(len(self.channels)))
elif isinstance(channels, int):
channels = (channels,)
images = []
for channel_idx in channels:
emission_flux = self.emission_flux(truth, channel_idx=channel_idx)
optical_image = self.optical_image(emission_flux, channel_idx=channel_idx)
images.append(self.digital_image(optical_image))
image = xr.concat(images, dim=Axis.C)

but that should be put higher up the chain, allowing someone to request any of emission_flux, optical_image, or digital_image and get the full channels output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant