Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled keyword not in every method #220

Closed
jakewilliami opened this issue Oct 31, 2021 · 1 comment · Fixed by #275
Closed

Enabled keyword not in every method #220

jakewilliami opened this issue Oct 31, 2021 · 1 comment · Fixed by #275

Comments

@jakewilliami
Copy link

jakewilliami commented Oct 31, 2021 •
edited
Loading

For example, Progress defined at line 106 (i.e., the method in which you specify the minimum update interval, dt) fails with the enabled keyword. My current workaround is

p = Progress(10_000_000, enabled = false)
p.dt = 1 # minimum update interval of 1 second
@MarcMush
Copy link
Collaborator

MarcMush commented Nov 9, 2021 •
edited
Loading

you can write

p = Progress(10_000_000; dt = 1, enabled = false)

IMO this is clearer and the definitions without keywords should be deprecated

@MarcMush MarcMush mentioned this issue Nov 12, 2021
Closed
@MarcMush MarcMush mentioned this issue Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate non-kwargs methods MarcMush/ProgressMeter.jl
2 participants
@MarcMush @jakewilliami