Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant display on finish!() #199

Closed
tomyun opened this issue May 5, 2021 · 2 comments · Fixed by #200
Closed

Redundant display on finish!() #199

tomyun opened this issue May 5, 2021 · 2 comments · Fixed by #200

Comments

@tomyun
Copy link

tomyun commented May 5, 2021

I believe this started happening since the recent update to ProgressMeter 1.6.0.

Screen Shot 2021-05-05 at 12 38 10 PM

julia> versioninfo()
Julia Version 1.6.1
Commit 6aaedecc44 (2021-04-23 05:59 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin18.7.0)
  CPU: Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, skylake)

IJulia is 1.23.2.

@tomyun
Copy link
Author

tomyun commented May 5, 2021

Indeed, it happens on REPL too.

julia> p = Progress(10; dt=0.1)
       for i in 1:10
           sleep(0.1)
           ProgressMeter.next!(p)
       end
       ProgressMeter.finish!(p)
Progress: 100%|████████████████████████████████████| Time: 0:00:01
Progress: 100%|████████████████████████████████████| Time: 0:00:01

@tomyun tomyun changed the title Redundant display on finish!() under IJulia Redundant display on finish!() May 5, 2021
@IanButterworth
Copy link
Collaborator

Thanks for the report. Some logic was omitted in #198 that made finish! print each time.

Fixed by #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants