Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with User selected Bible Translation being picked up when Group verse references are done. #249

Open
sushilsapru opened this issue Dec 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@sushilsapru
Copy link

Describe the bug
Ever since the recent release seeing issues with group verses defaulting to a different version, instead of the selected Default version.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Bible reference plugin settings and set your Bible version of choice (Example: ESV).
  2. Go to a new or existing note and enter a bible reference after "--" with more than 1 verse. Example: "--Rom1:1-4"
  3. It does not pick up the bible verse text for the default Bible translation I had selected (ESV) but instead defaults to another version.
  4. This issue is not seen when retrieving 1 verse reference.

Expected behavior
When referencing more than 1 bible verses. The user selected default bible translation version is to be picked up.

What Device Do You Use(please complete the following information):

  • Xiaomi Note 10 Pro (M2101K6P)
  • OS: Android 12
  • Version: 1.210908.001
@sushilsapru sushilsapru added the bug Something isn't working label Dec 13, 2024
@tim-hub
Copy link
Owner

tim-hub commented Dec 13, 2024

Oh, thanks for the feedback, I will have a look.

Besides that have you tried changed default version to a different one and change it back? Sometimes it could be caching.

@sushilsapru
Copy link
Author

Thanks a lot, Tim!
Appreciate you looking into this!

Yes I did try that and it seems to always default to a different Bible Translation. (Screenshot added)
And when I go back and check the Settings it shows as none selected and it seems to default to this always even if I select "ESV". (Screenshot added)

image
image

@tim-hub
Copy link
Owner

tim-hub commented Dec 13, 2024

I see, I can reproduce this issue too, I think it is related to this change #242

@tim-hub
Copy link
Owner

tim-hub commented Dec 13, 2024

Thanks a lot, Tim! Appreciate you looking into this!

Yes I did try that and it seems to always default to a different Bible Translation. (Screenshot added) And when I go back and check the Settings it shows as none selected and it seems to default to this always even if I select "ESV". (Screenshot added)

image image

I am releasing the new changes.

the reason is the regex conflict, I tried to get a better regex this morning, however, I could not,

so I changed the - to @ to make it work (FYI @Benedictteo05)

Anyway, the bug should be fixed in the new release https://github.com/tim-hub/obsidian-bible-reference/releases/tag/24.12.14-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants