Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters not rendering correctly with dev builds #2276

Closed
Maxszik opened this issue Apr 16, 2014 · 8 comments
Closed

Characters not rendering correctly with dev builds #2276

Maxszik opened this issue Apr 16, 2014 · 8 comments

Comments

@Maxszik
Copy link

Maxszik commented Apr 16, 2014

Using stable Tilemill no trouble rendering odd characters/letters by putting encoding="CP1252" in the advanced field. Using the developer build this doesn't help anymore, doesn't work. Using encoding=LATIN1 makes no difference.

Using Mac, Mavericks, shapefiles

stable
dev

@springmeyer
Copy link
Member

Thanks for the report! Are you perhaps referencing Unifont in your style? If so this is broken right now in dev builds due to https://github.com/mapbox/tilemill/issues/2272.

@Maxszik
Copy link
Author

Maxszik commented Apr 17, 2014

Minion Pro Italic...is that Unifont?

  • Tried with Helvetica Neue and it renders alright, who could have known... still I hope this might be fixed.

@springmeyer
Copy link
Member

Hmm, okay, then I'm not sure what changed and I don't know how to fix. Are you sure this occurred do to purely a TileMill upgrade and nothing else? If so would it be possible to provide a reduced testcase? Basically a standalone project that demonstrates the problem in newer TileMill and does not have the problem in older TileMill when you open it up successively?

@Maxszik
Copy link
Author

Maxszik commented Apr 17, 2014

But it sound like it could simply be the Unifont issue you mention above, no? Yes, certain it occurs purely due to Tilemill devbuild upgrade. The latest one and the one before it. Produce a reduced testcase? Sure if you'd pls let me know what it should look like and how you want it sent. The shape file used is one from Naturalearth that I've been tinkering with and modified a bit.

@springmeyer
Copy link
Member

No, it's not likely the unifont issue unless you are specifying that or the dejavu fonts in your style. Are you? Can you post your style for me to download?

On Apr 17, 2014, at 12:59 PM, maxmeles notifications@github.com wrote:

But it sound like it could simply be the Unifont issue you mention above, no? Yes, certain it occurs purely due to Tilemill devbuild upgrade. The latest one and the one before it. Produce a reduced testcase? Sure if you'd pls let me know what it should look like and how you want it sent. The shape file used is one from Naturalearth that I've been tinkering with and modified a bit.


Reply to this email directly or view it on GitHub.

@Maxszik
Copy link
Author

Maxszik commented Apr 18, 2014

I'm specifying a font called Minion Pro, don't know what that is exactly. Other fonts (ex Palatino Linotype) also don't work, while I found out that Helvetica Neue does.

You could download the shapefiles used here
https://www.dropbox.com/sh/8o51b6bvzdrznkw/SW74Rhibyk/rivermap-shps

and what I suppose is the relevant code below. The area in my example pic posted before was from the northern part of the river Ob' in West Siberia. I think you get the same issue if you zoom into the large lakes of Sweden that got å ä ö in them.

Ok? Happy Easter !

@water: #C0E0F8;
@waterline: #93B6E1;
@watertext: "Minion Pro Semibold Italic", "Minion Pro Medium Italic", "Palatino Linotype Italic", "Georgia Italic";
@Rivertext: "Minion Pro Italic", "Minion Pro Semibold Italic", "Minion Pro Medium Italic", "Palatino Linotype Italic", "Georgia Italic";
@watertextfill: #168;

Map [zoom>=3][zoom<=8]{ background-color: @water; buffer-size: 256;}

#ne50mriverslakecente [featurecla = "River"] { ::text [zoom>=4][zoom<=5]{
text-allow-overlap: false;
text-name: "[name]";
text-fill: @watertextfill;
text-face-name: @Rivertext;
text-placement: line;
text-halo-fill: fadeout(white, 30%);
text-halo-radius: 1.5;
text-character-spacing: 1.5;
text-avoid-edges: true;
[strokeweig>=0.149999991] { text-size: 9; text-opacity:0.7;}
[strokeweig>=0.36249999325] { text-size: 11; text-opacity:0.7;}
[strokeweig>=0.5749999955] { text-size: 13;text-opacity:0.75; }
[strokeweig>=0.7874999977499999] { text-size: 14; text-opacity:0.8;}
[strokeweig>=1] { text-size: 16; text-opacity:0.9;}
[zoom=4] { text-dy: 7; }
[zoom=5] { text-dy: 8; }}}

#ne10mriverslakecente [featurecla = "River"] { ::text [zoom>=6][zoom<=9]{
text-allow-overlap: false;
text-name: "[name]";
text-fill: @watertextfill;
text-face-name: @Rivertext;
text-placement: line;
text-halo-fill: fadeout(white, 30%);
text-halo-radius: 1.5;
text-character-spacing: 1.5;

[zoom=6] [strokeweig >= 0.15] { text-size: 9_1.2; text-opacity:0.6;}
[zoom=6] [strokeweig >= 0.2] { text-size: 10_1.2; text-opacity:0.7;}
[zoom=6] [strokeweig >= 0.25] { text-size: 11_1.2; text-opacity:0.8;}
[zoom=6] [strokeweig >= 3] { text-size: 12.5_1.2; text-opacity:0.9;}
[zoom=6] { text-dy: 9; }

[zoom=7] [strokeweig >= 0.15] { text-size: 9_1.6; text-opacity:0.6;}
[zoom=7] [strokeweig >= 0.2] { text-size: 10_1.6; text-opacity:0.7;}
[zoom=7] [strokeweig >= 0.25] { text-size: 11_1.6; text-opacity:0.8;}
[zoom=7] [strokeweig >= 3] { text-size: 12.5_1.6; text-opacity:0.9;}
[zoom=7] { text-dy: 11; }

[zoom=8] [strokeweig >= 0.15] { text-size: 9_2; text-opacity:0.6;}
[zoom=8] [strokeweig >= 0.2] { text-size: 10_2; text-opacity:0.7;}
[zoom=8] [strokeweig >= 0.25] { text-size: 11_2; text-opacity:0.8;}
[zoom=8] [strokeweig >= 3] { text-size: 12.5_2; text-opacity:0.9;}
[zoom=8] { text-dy: 12; }

[zoom=9] [strokeweig >= 0.15] { text-size: 9_2; text-opacity:0.6;}
[zoom=9] [strokeweig >= 0.2] { text-size: 10_2; text-opacity:0.7;}
[zoom=9] [strokeweig >= 0.25] { text-size: 11_2; text-opacity:0.8;}
[zoom=9] [strokeweig >= 3] { text-size: 12.5_2; text-opacity:0.9;}
[zoom=9] { text-dy: 13; }}}

@springmeyer
Copy link
Member

Could you please reduce the testcase further? Please boil the style down to one line ideally that still replicates the problem please.

@Maxszik
Copy link
Author

Maxszik commented Apr 26, 2014

Sorry new to this Githubthing. If you do like this:

Use Tilemill dev build, download and load the 50 Naturalearthdata.com shape files for rivers and lakes, and add text labels using the Minion Pro font.

Try zoom into for example the big lakes of Sweden and Finland.

Does not render correctly despite using encoding="CP1252".

@Komzpa Komzpa closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants