Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

{{link-to}} "disabledWhen" documentation wrong? #413

Closed
Fryie opened this issue Sep 16, 2015 · 7 comments
Closed

{{link-to}} "disabledWhen" documentation wrong? #413

Fryie opened this issue Sep 16, 2015 · 7 comments

Comments

@Fryie
Copy link

Fryie commented Sep 16, 2015

According to the documentation, {{link-to}} should work with a disabledWhen attribute that is evaluated dynamically (as opposed to the "static" disabled attribute). This also used to work in Ember 1.12. However, it doesn't seem to work as advertised: http://ember-twiddle.com/4bcac030ed2c19272271

Changing disabledWhen to disabled seems to work, however, and doesn't seem to be "static" at all (maybe I'm misunderstanding the labels static and dynamic here?).

@jcope2013
Copy link

related? emberjs/ember.js#12344

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 16, 2015

@jcope2013 is correct, emberjs/ember.js#12344 fixed the issue in the Ember release-1-13 branch. So I'm going to go ahead and close...

@rwjblue rwjblue closed this as completed Sep 16, 2015
@Fryie
Copy link
Author

Fryie commented Sep 16, 2015

sorry, just to follow up: in which release is this fixed? 'cause i'm running ember 1.13.7.

@jcope2013
Copy link

@Fryie add "ember": "#release-1-13" to your bower.json to get it now, it will be included in 1.13.11 but you can get it now by using the release branch (which is 1.13.10 + new fixes)

@Fryie
Copy link
Author

Fryie commented Sep 17, 2015

sweet, thanks a lot

@Fryie
Copy link
Author

Fryie commented Sep 17, 2015

just to clarify, though: why does the syntax with "disabled" work, even though it's supposed to be "static" as per the docs? is that also part of the fixed bug?

@Fryie
Copy link
Author

Fryie commented Sep 18, 2015

just to answer my own question, "disabled" only seems to work: it creates the right css class, so the link looks disabled, but it's actually clickable. I'll try updating ember and changing back to "disabledWhen". :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants