-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source maps specified in index.js but not included in blade #382
Comments
I like the idea of inlining them in non-production environments, they're bigger than Ziggy itself but still relatively tiny overall. Microbundle doesn't seem to support this but Rollup does and it looks straightforward, so I might PR it. As for using |
@bakerkretzmar This seems more like a bug than an enhancement to me. We are using
|
My PR to add support for inline sourcemaps was just merged into microbundle, so as soon as they tag a release this should be trivial to add. Thanks for your patience. Note to future me: in production just strip out the sourcemap line entirely to avoid error messages. |
Hi. I am using Safari and adding @routes to blade make pages unable to load anything because Safari returns a 404 error on sourcemaps "index.js.map". |
@graceoflives just released v1.0.5 👍🏻 |
Description
The dist js files specify a
sourceMappingUrl
, but since no source maps are included in blade it results in a developer console error, 404 forindex.js.map
.Proposed solution
Either completely skip source map in the build, or include them as part of the
@routes
directive (but then - should they be included in production or not?). Perhaps users could import the js using their build tool (leaving source map generation up to them), while using blade only for the JSON routes.The text was updated successfully, but these errors were encountered: