Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(system_monitor): disable gpu_monitor #770

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix(system_monitor): disable gpu_monitor #770

merged 1 commit into from
Aug 28, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Aug 25, 2023 •
edited
Loading

Description

  • NVMLのエラーにより、gpu_monitorが強制終了してしまうため、無効化する
  • 無効化する対象は以下の通り
    • gpu_monitorの起動
    • disgnostics_aggregatorのgpuの記載。これをコメントアウトしないと、 /autoware/system/resource_monitoring にてgpuがstaleしてしまうため

Related links

https://tier4.atlassian.net/browse/AEAP-723

Tests performed

psimを起動し

  • gpu_monitorが起動していないことを確認した
  • /autoware/system/resource_monitoring がgpu_monitor起因でエラーとならないことを確認した

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta
Copy link
Author

h-ohta commented Aug 25, 2023

@Mergifyio backport beta/v0.3.17

@mergify
Copy link

mergify bot commented Aug 25, 2023 •
edited
Loading

backport beta/v0.3.17

✅ Backports have been created

@h-ohta h-ohta requested a review from KeisukeShima August 25, 2023 10:00
KeisukeShima
KeisukeShima approved these changes Aug 25, 2023
View reviewed changes
Copy link

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit b21f684 into beta/v0.3.16 Aug 28, 2023
@h-ohta h-ohta deleted the fix/disable_gpu_monitor branch August 28, 2023 01:55
mergify bot pushed a commit that referenced this pull request Aug 28, 2023
@h-ohta @mergify
fix(system_monitor): disable gpu_monitor (#770)
5569131 
(cherry picked from commit b21f684)
@mergify mergify bot mentioned this pull request Aug 28, 2023
Merged
h-ohta added a commit that referenced this pull request Aug 28, 2023
@mergify @h-ohta
fix(system_monitor): disable gpu_monitor (backport #770) (#774)
6e26a1f 
fix(system_monitor): disable gpu_monitor (#770)

(cherry picked from commit b21f684)

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeisukeShima KeisukeShima KeisukeShima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-ohta @KeisukeShima