Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append is redundant #89

Closed
yaxu opened this issue Apr 23, 2022 · 2 comments
Closed

append is redundant #89

yaxu opened this issue Apr 23, 2022 · 2 comments
Labels
refactoring

Comments

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

Because strudel has varargs, cat can do everything that append does. Similarly stack does everything that overlay does in tidal.

Do we make append and overlay aliases of cat and stack? Or just not have them in strudel at all?
@felixroos felixroos mentioned this issue Apr 23, 2022
Open
74 tasks
@felixroos
Copy link
Collaborator

Maybe just remove them? I guess they are not that frequently used by tidal users, so it might be ok?

@yaxu
Copy link
Member Author

yaxu commented Apr 23, 2022

Ok agreed, I'll remove append. overlay isn't implemented yet anyway.

@yaxu yaxu closed this as completed in 6a6464b Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaxu @felixroos