Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hooks for Focus Trap and ESC listener and use in Modal, Popover and Tooltip #351

Merged
merged 17 commits into from
Jun 28, 2019
Merged

Create hooks for Focus Trap and ESC listener and use in Modal, Popover and Tooltip #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0dfbd7a
Refactor esc listener into hook and use in modal and popover
lavelle Jun 25, 2019
649a10f
Fixing tests
lavelle Jun 26, 2019
7dd06b3
Make a focus trap hook too
lavelle Jun 26, 2019
b5b14db
Use focus trap hook in popover
lavelle Jun 26, 2019
68928a9
Add a conditional portal utility and add JSDocs
lavelle Jun 26, 2019
855b5f3
Fix lint and update changelog
lavelle Jun 26, 2019
702ea0b
Fix test
lavelle Jun 26, 2019
84e5132
Add comment
lavelle Jun 26, 2019
9a944aa
Update more snapshots
lavelle Jun 26, 2019
4504ba8
Fix extensions for build
lavelle Jun 26, 2019
559a5a0
Merge branch 'master' into esc-listener-hook
lavelle Jun 26, 2019
ea32ea7
Merge branch 'master' into esc-listener-hook
lavelle Jun 26, 2019
907a9d3
Fix gatsby build
lavelle Jun 26, 2019
6fdb5fb
Respond to CR feedback
lavelle Jun 27, 2019
d70d08e
Merge branch 'master' into esc-listener-hook
lavelle Jun 27, 2019
2e56a96
Downgrade focus trap
lavelle Jun 27, 2019
f62b60f
Remove outline
lavelle Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/thumbprint-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@

## Unreleased

### Added

- [Patch] Create new hook for registering an ESC listener.
- [Patch] Create new hook for trapping focus.
- [Patch] Create new utility component for conditionally using portals.

### Changed

- [Patch] Refactor ModalCurtain to be a function component and use hooks.
- [Patch] Refactor Tooltip to use the new hooks.
- [Patch] Refactor Popover to use the new hooks.

### Fixed

- [Patch] Add `muted` theme to tertiary `Button` loading state to match the button's text color. (#352)
Expand Down
Loading