-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create hooks for Focus Trap and ESC listener and use in Modal, Popover and Tooltip #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
danoc
reviewed
Jun 26, 2019
packages/thumbprint-react/components/ModalDefault/__snapshots__/test.jsx.snap
Outdated
Show resolved
Hide resolved
danoc
requested changes
Jun 27, 2019
I'm getting this on Chrome when clicking on the button to open the popover. Can you either:
I'd personally prefer the first option but am open the second if you feel strongly. |
removed the outline |
danoc
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of this change:
Popover
,Tooltip
andModalCurtain
ModalCurtain
to a function component with hooks in order to allow it to use the new hooksNot doing:
The main Tooltip is still a class – converting it to be a function component should be another PR, since it has a lot of lifecycle hooks and state, and we want to make sure we don't break anything. When we do this, Tooltip can use the hook directly.
Converting the deprecated
ModalStandard
and it's underlyingModalBase
to use these hooks. These components have their own ESC handling, but it's not worth the effort to rewrite them as function components. We should work on removing uses in website and deleting them.