Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tooltip to use hooks #354

Closed
danoc opened this issue Jun 26, 2019 · 0 comments · Fixed by #355
Closed

Refactor Tooltip to use hooks #354

danoc opened this issue Jun 26, 2019 · 0 comments · Fixed by #355
Assignees

Comments

@danoc
Copy link
Member

danoc commented Jun 26, 2019

Tooltip would be a good one to do so that we can remove the EscapeableTooltip wrapper made in #351.

@lavelle lavelle self-assigned this Jun 27, 2019
lavelle added a commit that referenced this issue Jul 1, 2019
## This change includes:

- Refactoring Tooltip to be a function component, using hooks for state and effects
- Remove the intermediary EscapableTooltip (Fixes #354)
- Update all the unit tests to avoid using `setState()` and `state()` in favour of simulating clicks and asserting the DOM directly. This is compatible with hooks, and is a better design of black-box testing
- Split out server tests and run them in Jest's server environment
- Upgrade Enzyme (only a minor version bump) to support new Hooks testing features (see enzymejs/enzyme#2073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants