You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Just looking through the source of this theme and noticed that in functions.php/load_cornerstone_scripts() you're enqueuing /js/modernizr.foundation.js and then also enqueuing /js/foundation.min.js which includes modernizr already. Is this by design?
Also in /js/foundation.min.js you're loading jquery.js (v 1.9), but WordPress is already loading its own version. Is this also by design?
Thanks for any insight you can give me!
Cam
The text was updated successfully, but these errors were encountered:
I've removed modernizr. I'll look into the jQuery issue at a later time. To be honest I don't look this repository much any more as the main Cornerstone repository is where I focus my efforts using the latest versions of Zurb Foundation. I only left this up for anyone who really needed to use Foundation 3. I recently added in a CSS stylesheet for for IE8 users in the main Cornerstone repository so I can't see many people needing this one.
Yes, these are all good points. Just wanted to alert you to the fact as I just had a client come to me who had used this theme and they were having some issues that were resolved by removing the two 'extra' items of code. Ideally, of course, they would agree to move to the new Cornerstone. ;-)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
Just looking through the source of this theme and noticed that in functions.php/load_cornerstone_scripts() you're enqueuing /js/modernizr.foundation.js and then also enqueuing /js/foundation.min.js which includes modernizr already. Is this by design?
Also in /js/foundation.min.js you're loading jquery.js (v 1.9), but WordPress is already loading its own version. Is this also by design?
Thanks for any insight you can give me!
Cam
The text was updated successfully, but these errors were encountered: