Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to GitHub Actions #6175

Merged
merged 3 commits into from
May 7, 2021

Conversation

gregorbg
Copy link
Member

@gregorbg gregorbg commented May 7, 2021

See title. I expect this PR to take some time based on trial-and-error checks, since it is arguably hard to debug CI run without actually running the entire CI.

The Ruby gems at $HOME/.bundle will be automatically cached by the setup-ruby action. The MySQL password of the Ubuntu installation also has to be manually adjusted (the MySQL server that comes with GitHub Actions has root:root instead of Travis' root:[empty]) -> can we change our website Ruby code to use root:root?

Everything else should just be a 1:1 adaptation of the old Travis checks in the new GitHub Actions syntax.

@gregorbg gregorbg force-pushed the feature/github-actions branch from be0ca75 to e5438cb Compare May 7, 2021 17:01
@gregorbg gregorbg force-pushed the feature/github-actions branch 2 times, most recently from e97f787 to 688fda5 Compare May 7, 2021 17:11
@gregorbg gregorbg force-pushed the feature/github-actions branch from 688fda5 to 3bd9192 Compare May 7, 2021 17:24
@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Interesting observation: The CI currently fails because the overcommit checks demand that git --config user.name and user.email be set. In the GitHub Actions environment, they are not set by default.

@gregorbg gregorbg force-pushed the feature/github-actions branch from 3bd9192 to 0f04603 Compare May 7, 2021 17:50
@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Yay, first successful run! Only one non-critical failure about the API to Coveralls not being able to connect via SSL.

Apparently, this happens because the coveralls gem is deprecated and uses TLS 1.1, which was dropped in Ubuntu focal. Migrating to coveralls_reborn as per lemurheavy/coveralls-ruby#163

@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Ready for review!

@gregorbg gregorbg requested a review from a team May 7, 2021 18:26
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🎉 ❤️

Just some minor comments, please try setting up mysql8 as per one of the comments and we should be ready to go!

@gregorbg gregorbg force-pushed the feature/github-actions branch from e629a75 to c0fd7c5 Compare May 7, 2021 19:11
@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Had some minor troubles with getting everything uploaded to Coveralls, (potential) fix is already uploaded and running through CI as I write this comment!

@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

I have just realised that our previous Coveralls reports (via the Ruby coveralls gem) all cover the spec folder itself. Is this intended/desired?

SimpleCov itself filters the spec folder in its base configuration, implying that this shouldn't be tracked. I can fix our Simplecov to not track /spec but this would result in a significant coverage percentage drop (~96 to ~90). Please advise @jonatanklosko

@jonatanklosko
Copy link
Member

SimpleCov itself filters the spec filter in its base configuration, implying that this shouldn't be tracked. I can fix our Simplecov to not track /spec but this would result in a significant coverage percentage drop (~96 to ~90). Please advise @jonatanklosko

Ohh, interesting point! There are different opinions, but I think excluding the test files makes much sense, so I'm up for the new configuration.

I believe we are ready now, or do you want to investigate anything else?

@jonatanklosko
Copy link
Member

Ah, feel free to enable the restore-keys as mentioned.

@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Oki, will do! I'll also try out the rails configuration of SimpleCov to see if that changes anything significant

@gregorbg gregorbg force-pushed the feature/github-actions branch from c0fd7c5 to 9c94d59 Compare May 7, 2021 19:56
@gregorbg
Copy link
Member Author

gregorbg commented May 7, 2021

Hm, using the rails configuration for SimpleCov really messes things up it seems. I will revert to the status quo including the spec folder and we can worry about handling of coverage in a separate PR to keep concerns clean and my mind sane.

@gregorbg gregorbg force-pushed the feature/github-actions branch from 9c94d59 to cd47603 Compare May 7, 2021 20:16
@gregorbg gregorbg merged commit f7b72d9 into thewca:master May 7, 2021
@gregorbg gregorbg deleted the feature/github-actions branch May 7, 2021 20:31
@jonatanklosko
Copy link
Member

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants