-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis CI to GitHub Actions #6175
Conversation
be0ca75
to
e5438cb
Compare
e97f787
to
688fda5
Compare
688fda5
to
3bd9192
Compare
Interesting observation: The CI currently fails because the |
3bd9192
to
0f04603
Compare
Yay, first successful run! Only one non-critical failure about the API to Coveralls not being able to connect via SSL. Apparently, this happens because the |
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 🎉 ❤️
Just some minor comments, please try setting up mysql8 as per one of the comments and we should be ready to go!
e629a75
to
c0fd7c5
Compare
Had some minor troubles with getting everything uploaded to Coveralls, (potential) fix is already uploaded and running through CI as I write this comment! |
I have just realised that our previous Coveralls reports (via the Ruby SimpleCov itself filters the |
Ohh, interesting point! There are different opinions, but I think excluding the test files makes much sense, so I'm up for the new configuration. I believe we are ready now, or do you want to investigate anything else? |
Ah, feel free to enable the |
Oki, will do! I'll also try out the |
c0fd7c5
to
9c94d59
Compare
Hm, using the |
9c94d59
to
cd47603
Compare
Awesome work! |
See title. I expect this PR to take some time based on trial-and-error checks, since it is arguably hard to debug CI run without actually running the entire CI.
The Ruby gems at
$HOME/.bundle
will be automatically cached by thesetup-ruby
action. The MySQL password of the Ubuntu installation also has to be manually adjusted (the MySQL server that comes with GitHub Actions hasroot:root
instead of Travis'root:[empty]
) -> can we change our website Ruby code to useroot:root
?Everything else should just be a 1:1 adaptation of the old Travis checks in the new GitHub Actions syntax.