From 0d238ac1168abe98531ea26d6f835347e97e7f20 Mon Sep 17 00:00:00 2001
From: Ravi Lachhman <42775804+ravilach@users.noreply.github.com>
Date: Wed, 4 May 2022 12:30:25 -0400
Subject: [PATCH 1/3] Update CONTRIBUTING.md

Updated
---
 CONTRIBUTING.md | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 0c66e919..a319284a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -87,3 +87,19 @@ During development, you may need to utilize some `make` utils to update generate
 
 ## Submission Guidelines
 Ketch follows a lightweight Pull Request process. When submitting a PR, answering a few [basic questions](https://github.com/theketchio/ketch/blob/main/.github/pull_request_template.md) around type of change and steps to test and you are well on your way to a PR approval.   
+
+### Your First Ketch Pull Request
+Please Fork the project and create a branch to make your changes to. Directly commit your changes to your branch and then when 
+ready to merge upstream, feel free to and create a PR. There are quality steps that need to be achieved. 
+
+`git checkout -b add-ketch-feature-of-squash-bug`
+
+#### Running Tests
+Depending where you are contributing e.g Ketch Controller, Ketch CLI, there are included tests to run. 
+
+##### Ketch App CLI
+`./cli_tests/app.sh`
+[Ketch App CLI Tests](https://github.com/theketchio/ketch/blob/main/cli_tests/job.sh#L3-L8)
+
+`./cli_tests/job.sh`
+[Ketch Jobs CLI Tests](https://github.com/theketchio/ketch/blob/main/cli_tests/job.sh#L3-L8)

From 952a216ec580c1339653c28ea0d4b6372ce269e5 Mon Sep 17 00:00:00 2001
From: Ravi Lachhman <42775804+ravilach@users.noreply.github.com>
Date: Thu, 5 May 2022 12:53:32 -0400
Subject: [PATCH 2/3] Update CONTRIBUTING.md

Updated Contributing Guide
---
 CONTRIBUTING.md | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a319284a..fced2e01 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -88,18 +88,42 @@ During development, you may need to utilize some `make` utils to update generate
 ## Submission Guidelines
 Ketch follows a lightweight Pull Request process. When submitting a PR, answering a few [basic questions](https://github.com/theketchio/ketch/blob/main/.github/pull_request_template.md) around type of change and steps to test and you are well on your way to a PR approval.   
 
-### Your First Ketch Pull Request
+## Your First Ketch Pull Request
 Please Fork the project and create a branch to make your changes to. Directly commit your changes to your branch and then when 
 ready to merge upstream, feel free to and create a PR. There are quality steps that need to be achieved. 
 
 `git checkout -b add-ketch-feature-of-squash-bug`
 
-#### Running Tests
-Depending where you are contributing e.g Ketch Controller, Ketch CLI, there are included tests to run. 
+### Running Tests
+As a good practice, locally running the integration tests is a good idea. Because during the CI Step e.g GitHub Actions, these will be
+run again as a quality gate. 
+
+#### Unit Tests
+Unit test coverage is in place. Running "make test" will run all of the Unit Tests e.g "Go Test". 
+`make test`
+
+Test coverage is represented as files suffixed as "test". A good idea is to include Unit Tests
+with your changes. 
+
+[Example Unit Test](https://github.com/theketchio/ketch/blob/main/internal/controllers/app_controller_test.go)
+
+#### Ketch CLI
+The CLI has integration tests if you are making CLI level changes. These tests will run the
+CLI against a live Ketch Installation. 
 
-##### Ketch App CLI
 `./cli_tests/app.sh`
-[Ketch App CLI Tests](https://github.com/theketchio/ketch/blob/main/cli_tests/job.sh#L3-L8)
+[Ketch App CLI Tests](https://github.com/theketchio/ketch/blob/main/cli_tests/app.sh#L3-L8)
 
 `./cli_tests/job.sh`
 [Ketch Jobs CLI Tests](https://github.com/theketchio/ketch/blob/main/cli_tests/job.sh#L3-L8)
+
+### Submitting PR
+When you commit via GitHub, there will be GitHub Actions that is ran on your behalf. 
+[GitHub Actions Config](https://github.com/theketchio/ketch/blob/main/.github/workflows/deploy.yaml#L50-L89)
+
+The GitHub Actions will create a temporary K3d cluster on the GitHub Actions Agent to run the tests. 
+
+Assuming everything passes in your branch, you are now ready to create a Pull Request and get ready for the merge. 
+
+#### PR Acceptance
+Currently, one Core Contributor will have to accept the Pull Request. Thanks for your PR!

From 7f21d1dbfc25c27a22890555ea32e0b92f2f4631 Mon Sep 17 00:00:00 2001
From: Ravi Lachhman <42775804+ravilach@users.noreply.github.com>
Date: Thu, 5 May 2022 13:01:21 -0400
Subject: [PATCH 3/3] Create  CONTRIBUTORS.md

Created Contributors
---
 CONTRIBUTORS.md | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 CONTRIBUTORS.md

diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
new file mode 100644
index 00000000..b7d97445
--- /dev/null
+++ b/CONTRIBUTORS.md
@@ -0,0 +1,14 @@
+Here is a list of Contributors to the Ketch Project. 
+
+# Core Contributors 
+
+* [John Shenk](https://github.com/stinkyfingers)
+* [Aleksej Paschenko](https://github.com/aleksej-paschenko)
+* [Ravi Lachhman](https://github.com/ravilach)
+* [Vivek Pandey](https://github.com/vivek)
+* [David French](https://github.com/DavisFrench)
+* [Stevan Koncar](https://github.com/koncar)
+* [Kumar Saurabh](https://github.com/itsksaurabh)
+* [Kavin Aravind](https://github.com/kavinaravind)
+
+Thanks so much for your contributions!