Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant join rooms server isn't already present within via aliases #460

Closed
TheArcaneBrony opened this issue Jun 24, 2024 · 4 comments
Closed
Labels
blocks release used in exceptional circumstances when the `latest` tag would break bug Something isn't working L3 Some Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios.

Comments

@TheArcaneBrony
Copy link
Contributor

TheArcaneBrony commented Jun 24, 2024

image
Draupnir 2.0.0-beta.4

@FSG-Cat FSG-Cat added bug Something isn't working L5 All Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios. blocks release used in exceptional circumstances when the `latest` tag would break labels Jun 24, 2024
@Gnuxie
Copy link
Member

Gnuxie commented Jun 24, 2024

This issue is caused by a bunch of shortfalls in the handling of room aliases

https://github.com/Gnuxie/matrix-protection-suite/blob/main/src/MatrixTypes/MatrixRoomReference.ts#L63 needs editing so that the server name is taken from the end at a minimum

https://github.com/Gnuxie/matrix-protection-suite-for-matrix-bot-sdk/blob/main/src/Client/BotSDKBaseClient.ts#L130-L155 needs changing to take the servers from the response https://spec.matrix.org/v1.10/client-server-api/#get_matrixclientv3directoryroomroomalias. I don't think the matrix-bot-sdk gives access to them but we can fix that.

https://github.com/Gnuxie/matrix-protection-suite-for-matrix-bot-sdk/blob/main/src/Client/BotSDKBaseClient.ts#L157-L178 Could be changed to call /join directly on aliases.

@Gnuxie Gnuxie changed the title Cant join room via alias Cant join rooms server isn't already present within via aliases Jun 24, 2024
@Gnuxie Gnuxie added L4 Most Users Likelihood L3 Some Users Likelihood and removed L5 All Users Likelihood L4 Most Users Likelihood labels Jun 24, 2024
@Gnuxie
Copy link
Member

Gnuxie commented Jun 24, 2024

Changed likelihood because it's unusual to deploy draupnir on a different server to one you are using or have no users using.

@FSG-Cat
Copy link
Member

FSG-Cat commented Jun 24, 2024

Makes complete sense that those specific criteria change likelihood of running into it. I was assuming all alias resolution was going to not work when assigning labels.

@FSG-Cat
Copy link
Member

FSG-Cat commented Aug 1, 2024

Another example of this bug spotted in the wild in https://matrix.to/#/!IaWNErZAgQUhGqJXjX:matrix.org/$jM_Oa-YPWXDSGeQfz6UsCCevpndbWU6BT4cBF0ppy1U?via=matrix.org&via=envs.net&via=ubuntu.com conversation in the matrix room.

So clearly this bug has been run into by 2 users now who have reported it to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks release used in exceptional circumstances when the `latest` tag would break bug Something isn't working L3 Some Users Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T5 Major usability Impairs usability in key scenarios.
Projects
Status: Done
Development

No branches or pull requests

3 participants