Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize image #1280

Open
BiglifeMatt opened this issue Oct 11, 2023 · 7 comments
Open

Resize image #1280

BiglifeMatt opened this issue Oct 11, 2023 · 7 comments

Comments

@BiglifeMatt
Copy link

I know there was a previous request for this but it was closed with the CKEditor as an option. I do not even see that as a plugin option anymore and would still love a handle-based resize tool if possible.

@the-djmaze
Copy link
Owner

In #262 i explain why it is bad to use the CKEditor (or any other) image resizer.

At the end of that issue there's a commit that forces images to be a maximum of 1024px
6129fb4

That code could be enhanced to allow more "shrink" but not enlarge!

@BiglifeMatt
Copy link
Author

Will ckeditor 5 be included as an extension? I'm not concerned with the file size, only the appearance of inline images.

@the-djmaze
Copy link
Owner

the-djmaze commented Oct 30, 2023

I understand you, but people like to put 5-10 images of their family foto's inline and send 25+MB emails that get bounced by recipients.

CKEditor5 does not solve that, but someone might develop the integration.
I could push some draft code to github

@grrosminet
Copy link

In #262 i explain why it is bad to use the CKEditor (or any other) image resizer.

At the end of that issue there's a commit that forces images to be a maximum of 1024px 6129fb4
resizing image to 1024px max is very limitative : today people's screens are getting even more larger

Even if Rainloop only resizes image display (and not it's real weight) it allows you to completely manage the formatting of your e-mail, easily and quickly. Of course it might be better to really reduce image weight (but not always)

Moreover, you can create JPEG/PNG images that are only a few hundreds kb and very large

That code could be enhanced to allow more "shrink" but not enlarge!

Why ?! let user decide ! If the user want to resize a 100px image to 10000px why not, it's ugly and that's his problem

@the-djmaze
Copy link
Owner

the-djmaze commented Jan 12, 2024

Why ?! let user decide ! If the user want to resize a 100px image to 10000px why not, it's ugly and that's his problem

Maybe use this option:

<a href="cid:original-size"><img src="cropped"></a>

And the cid is the original sized image (including private metadata like the camera used aka EXIF data).
The user can then still decide to delete the original from the attachments area

@grrosminet
Copy link

That's all we are asking for : an interface that will allow lambda user to insert html attributes without having to be html dev.

@fabiodepin
Copy link

Hello,

I have this feature ready
#1593

As soon as possible, I will carry out the necessary validations to request PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants