Thanos query param dedup does not take effect after add externalLabels for prometheus and thanos-ruler?

[magiceses]

Thanos, Prometheus and Golang version used: thanos v0.31.0

What happened:
After add external label to thanos ruler, when i query metric through thanos-query

the param is not taking effect? and the metrics on the second and third lines are exactly the same, just like:

and when i change the label to {host_ip="10.20.0.7"}, the metric become to one metric? why?

How to reproduce it (as minimally and precisely as possible):
add the same external label to prometheus and thanos ruler

Anybody can help? This is a bug for thanos or i ignore some settings after add external labels?

[MichaHoffmann]

0.31 has had known dedup issues, can you try upgrading?

[magiceses]

ok, i can try it , can i ask which issue or which patch is already repair it? @MichaHoffmann

[MichaHoffmann]

There were a couple, the root cause was in the end that the store apis could under some circumstances involving external labels return unsorted responses but dedup replies on them being sorted

[magiceses]

what mean the store apis? I do not use thanos store gateway, i just use the sidecar/query/ruler;
you mean thanos-ruler?

[MichaHoffmann]

Ah, I mean the gRPC store api; all of them implement it on one way or another!

[magiceses]

Got it , thanks very much.
By the way, does the 0.31.0 version bug you mentioned above refer to this link(#6257 (comment)) can explain the problem?

[MichaHoffmann]

Got it , thanks very much. By the way, does the 0.31.0 version bug you mentioned above refer to this link(#6257 (comment)) can explain the problem?

Yes precisely that!

[magiceses]

execuse me, when i upgrade thanos-ruler from 0.31.0 to 0.32.0/0.33.0, the thanos ruler raise error:

Thanos-ruler cannot be upgraded directly from 0.31.0 to higher version? what else do i need to do? @MichaHoffmann

[MichaHoffmann]

I think that is a case of https://github.com/thanos-io/thanos/pull/6107 and might need some solution like https://github.com/utilitywarehouse/thanos-manifests/pull/77/files maybe!

[magiceses]

it works! Thank you very much!!

[MichaHoffmann]

You're welcome!