rules-check doesn't accept globs as described in the documentation

[gregoryfranklin]

The example rules-check command states that rules-check takes a glob of rules files

./thanos tools rules-check --rules cmd/thanos/testdata/rules-files/*.yaml

https://thanos.io/v0.19/components/tools.md/#rules-check
But this does not work for me.

You either get shell expansion of the glob, resulting in:

./thanos tools rules-check --rules config/rules/*.yaml
error parsing commandline arguments: [/bin/thanos tools rules-check --rules config/rules/file1.yaml config/rules/file2.yaml]: unexpected config/rules/file2.yaml
thanos: error: unexpected config/rules/file2.yaml

Or without shell expansion:

./thanos tools rules-check --rules=config/rules/*.yaml
error parsing commandline arguments: [/bin/thanos tools rules-check --rules=config/rules/*.yaml]: path 'config/rules/*.yaml' does not exist
usage: thanos tools rules-check --rules=RULES

The only form that does work is

./thanos tools rules-check --rules config/rules/file1.yaml --rules config/rules/file2.yaml

This is either a documentation error or the glob handling is not working.

[GiedriusS]

It seems like we use ExistingFiles() which allows you to specify multiple files that exist but it doesn't support regular expressions. IMHO we should add support for that. Help wanted!

[rhassanein]

Which version is this fixed in? I just ran into it in both v0.20.1 and v0.20.2.