Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanos inspect web command for block states in object storage. #1246

Closed
bwplotka opened this issue Jun 12, 2019 · 6 comments
Closed

thanos inspect web command for block states in object storage. #1246

bwplotka opened this issue Jun 12, 2019 · 6 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Jun 12, 2019

@jaseemabid on #thanos-dev slack here:

At Monzo we made some UI for the state of thanos compact because it was getting pretty difficult for us to visualise the progress. We had a huge backlog and our block sizes were pretty big and we weren't making any progress with downsampling. Last weekend is the first time since April we have actually managed to downsample anything and now we are back on track!

See the screenshot along. Old state on top, new state below.
Each new red block is a 2 week long block with 5m resolution.
Each new yellow block is a 2 week long block with 1h resolution. 🚀

image (4)

Its slightly interactive; here is a raw html file to play with.
Question for the thanos dev community.

Right now, this is generated by parsing the output of thanos bucket and its pretty brittle and specific to Monzo's setup. How should I think of upstreaming this work if there is sufficient interest?

  1. A UI for thanos compact like query? Add a web interface, make it look roughly the same with the same bootstrap libraries?
  2. A separate web project? $ thanos bucket web or something?
  3. Something else?

The current decision is to fit this into thanos bucket web command as alternative to CLI thanos bucket inspect (:

Thanks @jaseemabid for proposing this.

@metalmatze
Copy link
Contributor

This is now a duplicate of #1248, is it?

@brancz
Copy link
Member

brancz commented Jun 13, 2019

#1248 is the PR for this issue. Once merged, we can close this I'd say.

@jaseemabid
Copy link
Contributor

jaseemabid commented Jun 28, 2019

Rework thanos bucket UI; notes for a v2

The initial version at #1248 does the job, but leaves a lot desired. I'd love to get it out to a bunch of people, see what works, get some feedback and iterate for a v2. Can use this ticket to track progress.

  1. Remove Google charts; its very limited, proprietary and cannot be vendored. It looks like we already pull in d3.js, it would be nice to stick with that and not add a new dependency.
  2. Add filtering support for time ranges as well as labels.
  3. Make those labels look less horrifying.
  4. Explain the color legends.
  5. Add all the relevant info to tooltip popup

@Reamer
Copy link

Reamer commented Jun 28, 2019

Hi @jaseemabid,
Thanks for your work. I tried your web overview service. What is the meaning of the colors? A color legend would be nice.
grafik

@jojohappy
Copy link
Member

@bwplotka @brancz could we close this issue since #1248 has been merged?

@brancz
Copy link
Member

brancz commented Jul 11, 2019

Indeed. Thanks for the awesome and hard work!

@brancz brancz closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants