Fixes Cameras views on clients 515.1615 or greater #80818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yogstation sends its regards |
|
Fixes #79954 |
|
good first PR |
SyncIt21
suggested changes
Jan 6, 2024
Easy ones Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
Make sure to add this to your PR body |
SyncIt21
reviewed
Jan 6, 2024
LemonInTheDark
requested changes
Jan 8, 2024
LemonInTheDark
requested changes
Jan 9, 2024
Comment on lines
16
to
17
| /// Due to a Byond bug where secondary maps have improperly offset render targets, we will need to override this to "LEFT,TOP" for clients >515.1614 | ||
| var/relay_loc = "CENTER" |
There was a problem hiding this comment.
It's better to document what this DOES rather then why it's here, since why it's here might change given time
If it doesn't and none finds another use for this we can just rip it out when we deprecate the older client versions
There was a problem hiding this comment.
i think i better explained
comfyorange
added a commit
that referenced
this pull request
Jan 9, 2024
Jolly-66
pushed a commit
to TaleStation/TaleStation
that referenced
this pull request
Jan 9, 2024
…ter (#9359) Original PR: tgstation/tgstation#80818 ----- ## About The Pull Request Fixes tgstation/tgstation#79954 Turns out the cause of cameras breaking was something weird with how Byond determined the CENTER location for screen_locs on secondary popup maps like cameras and the spyglass. This can be remedied by manually using the LEFT,TOP position for the plane relays. However LEFT,TOP breaks the views for clients 1614 and below so I included a jank solution that should allow any client up to this point have the screen displayed correctly ### 515.1609 views working  ### 515.1623 views working  ## Why It's Good For The Game Cameras working passed 1614 means you can update the server. At some point I suspect Lummox will fix the CENTER position on secondary maps and when that happens it will likely break the current fix. ## Changelog :cl: fix: popup screen locs will work on clients >1614. Security cameras and Spyglass will work /:cl: Co-authored-by: Chubbygummibear <46236974+Chubbygummibear@users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Absolucy
referenced
this pull request
in Absolucy/Monkestation
Jan 18, 2024
## About The Pull Request Fixes tgstation/tgstation#79954 Turns out the cause of cameras breaking was something weird with how Byond determined the CENTER location for screen_locs on secondary popup maps like cameras and the spyglass. This can be remedied by manually using the LEFT,TOP position for the plane relays. However LEFT,TOP breaks the views for clients 1614 and below so I included a jank solution that should allow any client up to this point have the screen displayed correctly ### 515.1609 views working  ### 515.1623 views working  ## Why It's Good For The Game Cameras working passed 1614 means you can update the server. At some point I suspect Lummox will fix the CENTER position on secondary maps and when that happens it will likely break the current fix. ## Changelog :cl: fix: popup screen locs will work on clients >1614. Security cameras and Spyglass will work /:cl: --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Ghommie
added a commit
that referenced
this pull request
Feb 7, 2025
## About The Pull Request Closes: #89330 Replaced old hacky workaround #80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
nevimer
pushed a commit
to Bubberstation/Bubberstation
that referenced
this pull request
Feb 7, 2025
## About The Pull Request Closes: tgstation/tgstation#89330 Replaced old hacky workaround tgstation/tgstation#80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
Feb 8, 2025
## About The Pull Request Closes: tgstation/tgstation#89330 Replaced old hacky workaround tgstation/tgstation#80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
lessthnthree
pushed a commit
to effigy-se/effigy
that referenced
this pull request
Feb 9, 2025
## About The Pull Request Closes: tgstation/tgstation#89330 Replaced old hacky workaround tgstation/tgstation#80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
FlufflesTheDog
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Feb 11, 2025
## About The Pull Request Closes: tgstation/tgstation#89330 Replaced old hacky workaround tgstation/tgstation#80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Iajret
pushed a commit
to Fluffy-Frontier/FluffySTG
that referenced
this pull request
Feb 19, 2025
## About The Pull Request Closes: tgstation/tgstation#89330 Replaced old hacky workaround tgstation/tgstation#80818 with brand new hacky workaround. ## Why It's Good For The Game It is ## Changelog :cl: fix: fixed camera consoles, spyglasses etc. client crush on 516 /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #79954
Turns out the cause of cameras breaking was something weird with how Byond determined the CENTER location for screen_locs on secondary popup maps like cameras and the spyglass. This can be remedied by manually using the LEFT,TOP position for the plane relays. However LEFT,TOP breaks the views for clients 1614 and below so I included a jank solution that should allow any client up to this point have the screen displayed correctly
515.1609 views working
515.1623 views working
Why It's Good For The Game
Cameras working passed 1614 means you can update the server. At some point I suspect Lummox will fix the CENTER position on secondary maps and when that happens it will likely break the current fix.
Changelog
🆑
fix: popup screen locs will work on clients >1614. Security cameras and Spyglass will work
/:cl: