Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on LogStrategy is wrong as it talks about HTTP Strategy and how it talks to port 80 and waits for 200 status code #240

Closed
krisctl opened this issue Sep 11, 2020 · 0 comments · Fixed by #256
Closed

Comment on LogStrategy is wrong as it talks about HTTP Strategy and how it talks to port 80 and waits for 200 status code #240

krisctl opened this issue Sep 11, 2020 · 0 comments · Fixed by #256
Labels
documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest.

Comments

@krisctl
Copy link

krisctl commented Sep 11, 2020

Here is the comment in question:

testcontainers-go/wait/log.go

Line 24 in 8c68827

// NewLogStrategy constructs a HTTP strategy waiting on port 80 and status code 200

@gianarb gianarb added type/bug documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest. labels Sep 21, 2020
@Bablzz Bablzz mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: comment log strategy
2 participants
@gianarb @krisctl