-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support an option to add minitest-handler to run list #22
Comments
Heh, I wonder if this is truly a common happy path for most users currently--it hasn't been for me yet. Good news is that the init task is just a starting point. If we went down this path we'd also have to add these cookbooks to the Berksfile as well. |
Perhaps this could just be an extension of the converter I want per #19? |
@jtimberman that would be worth a spike, it would save someone (like you, say) a lot of time in a migration. |
Yeah I might just build a gem to do it out of band of this :). |
@jtimberman do you still see value in this? |
I could see this as a kitchen init --with-minitest-handler and have it set up a basic minitest suite for you in your cookbook. |
For a future version perhaps but not required for 1.0. I'd like to see the scaffolding tests created too. |
I have no opinion on versioning; but scaffolding the tests would make it a lot easier for starters. |
Okay. I'm going to mark this as 2.0. We can push it into 1.1 or something, but it's currently marked 1.0 and I don't think it should block the 1.0 release 😄 |
@sethvargo should this go into chefdk generators? |
If we're being prescriptive with people in ChefDK, should we be telling them to use ServerSpec and not do this feature? |
👍 |
Down with this and up with server spec. |
To facilitate running tests under minitest-chef handler automatically, the default suite should include
minitest-handler
in the run list if a command-line option to the init command is specified. Currently:Proposed:
The text was updated successfully, but these errors were encountered: