Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams may no longer be zoomed in/out in browser #952

Closed
pangloss opened this issue Mar 2, 2023 · 2 comments · Fixed by #944
Closed

Diagrams may no longer be zoomed in/out in browser #952

pangloss opened this issue Mar 2, 2023 · 2 comments · Fixed by #944

Comments

@pangloss
Copy link

pangloss commented Mar 2, 2023

Hi there,

I use D2 to analyze some moderately large networks, sometimes with 2k nodes or more. Prior to the latest update it worked very well, but now that it's locked to 100% zoom, even 100 node diagrams are hard to read, and larger diagrams are rendered illegibly small.

A few versions ago, diagrams were not scaled to the viewport size. That was by far the best configuration for my purposes, but at least prior to v0.2.2, I could zoom my browser in and out of diagrams and was able to get things the scale I needed. In the latest version that is no longer possible.

Could you please provide a way to specify fixed scaling of diagrams? This is the solution I'd prefer, but if there is a reason that's not possible, not locking the browser to a fixed zoom level would work for me.

The diagrams that I get from the system are sometimes very large like the one I've included below. The bigger ones like this one sometimes take 2-3 minutes to render, but that's no problem because they can be extremely useful and are worth waiting for!

Thanks for a super useful tool!
Darrick

image

@cyborg-ts cyborg-ts added this to D2 Mar 2, 2023
@alixander
Copy link
Collaborator

hey @pangloss sorry about that. it's a regression that's in the next release (aim to be tmr or friday latest): https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/next.md#bugfixes-%EF%B8%8F

btw while we're on the subject, would you care to chime in on #945 ? it was also something that changed recently and we just wanted to hear what other zoom-users prefer

@gavin-ts gavin-ts linked a pull request Mar 2, 2023 that will close this issue
@alixander
Copy link
Collaborator

this should be fixed in 0.2.3

@github-project-automation github-project-automation bot moved this to Done in D2 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants