Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 0-1 decimal value as percentages for border-radius #947

Closed
alixander opened this issue Mar 1, 2023 · 3 comments · Fixed by #1006
Closed

use 0-1 decimal value as percentages for border-radius #947

alixander opened this issue Mar 1, 2023 · 3 comments · Fixed by #1006
Assignees
Labels
good first issue Good for newcomers

Comments

@alixander
Copy link
Collaborator

border-radius people may want either percentage (namely, 50% for the "pill" shape), or a px value.

#913 (comment)

@cyborg-ts cyborg-ts added this to D2 Mar 1, 2023
@alixander alixander added the good first issue Good for newcomers label Mar 1, 2023
@Poivey
Copy link
Contributor

Poivey commented Mar 2, 2023

Hello, I would like to start contributing and this issue looks like a good first step. Would you mind assigning the issue to me?

To make sure I understand, [0,1[ values would be considered a percentage value, and [1, infinity] a pixel value ? Do we also need to accept values like 50% ?

@alixander
Copy link
Collaborator Author

sounds good! i think (0, 1), idk what 100% border radius would even mean lol.

no 50%, too much parsing hassle.

@alixander
Copy link
Collaborator Author

closed per discussion in #1006

@alixander alixander closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
@github-project-automation github-project-automation bot moved this to Done in D2 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants