Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border-radius has no effect #592

Closed
JakobTSutton opened this issue Jan 2, 2023 · 5 comments
Closed

border-radius has no effect #592

JakobTSutton opened this issue Jan 2, 2023 · 5 comments
Labels
feature Something new good first issue Good for newcomers render

Comments

@JakobTSutton
Copy link

JakobTSutton commented Jan 2, 2023

The docs only provides this information:

# Only applicable to shapes, except ovals
# Integer betwen 0 and 20
border-radius: 4

I'm guessing it works like the CSS counterpart "border-radius CSS property rounds the corners of an element's outer border edge"
However when applying this style to any shape (except the circle) nothing happens.
Example:

foo.shape: "square"
foo.style.border-radius: 20

[Edit] This was tested on the D2 Playground

@alixander
Copy link
Collaborator

#688

@github-project-automation github-project-automation bot moved this to Done in D2 Jan 20, 2023
@exolab
Copy link

exolab commented Feb 8, 2023

That still doesn't work for me in v0.1.16

dang: {
  style.border-radius: 20
}

@alixander
Copy link
Collaborator

@exolab does it not look like this?

https://play.d2lang.com/?script=SknMS7dSqOZSUAAbpocSB1YKRgZctVyAAAAA__8%3D&

when you run d2 version it shows 0.1.6? (not 16)

@exolab
Copy link

exolab commented Feb 8, 2023

I was surprised to see it working on my mobile phone when I read your message. Went back and checked in Chromium: works fine. But it doesn't round the corners in Firefox 109.0.1 (64-bit) on my Arch Linux laptop.

@alixander
Copy link
Collaborator

oh interesting! Looks like it's a firefox-specific thing then. thank you for reporting this, will track here: #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new good first issue Good for newcomers render
Projects
Status: Done
Development

No branches or pull requests

3 participants