Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_resource_missing_tags doesn't read tags_all #303

Closed
lays147 opened this issue Jan 26, 2022 · 2 comments
Closed

aws_resource_missing_tags doesn't read tags_all #303

lays147 opened this issue Jan 26, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@lays147
Copy link

lays147 commented Jan 26, 2022

Hi,
In our company we are using TFLint with a set of rules. One of them is to check the tags in the terraform code. However, I've noticed that the default_tags -> tags_all used in the aws provider are not considered when evaluating the rule.

What would be the way to fix it? I may push a PR if you point me out.

I was able to find that the name of the variable is defined here, but my Golang knowledge is short to understand all the logic defined there.

Cheers,

@wata727
Copy link
Member

wata727 commented Jan 28, 2022

Duplicate of #192

The logic for getting the default_tags is a bit complicated and probably not an easy fix. The SDK's documentation may be helpful.
https://pkg.go.dev/github.com/terraform-linters/tflint-plugin-sdk

However, I'm currently planning a major update to the plugin API, which may be better after it is complete.

@wata727 wata727 added the duplicate This issue or pull request already exists label Jan 28, 2022
@PatMyron
Copy link
Contributor

pinned #117 for visibility

@bendrucker bendrucker closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Development

No branches or pull requests

4 participants