Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to readme #24

Closed
greenozon opened this issue Jun 10, 2024 · 6 comments · Fixed by #25
Closed

Updates to readme #24

greenozon opened this issue Jun 10, 2024 · 6 comments · Fixed by #25

Comments

@greenozon
Copy link
Contributor

greenozon commented Jun 10, 2024

Minor ticket to actualize readme page

current readme states:

Set AWS provider's region to us-east-1 or sa-east-1 when using [modules/pricing](https://github.com/terraform-aws-modules/terraform-aws-pricing/tree/master/modules/pricing) because AWS Pricing service is only available in these regions.
  1. there is no region as sa-east-1 as stated in the readme
    I believe this should be ap-south-1

  2. current list of AWS regions that supports pricing querying is as follows:

▶ $ aws pricing describe-services --region us-east-1
▶ $ aws pricing describe-services --region eu-central-1
▶ $ aws pricing describe-services --region ap-south-1

it means +1 new region: eu-central-1

The idea is to update readme and make it up-to-date

thanks

Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 11, 2024
@greenozon
Copy link
Contributor Author

hi @antonbabenko hwdy!
any chance to review above micro PR please?

Glory to Ukraine!

@github-actions github-actions bot removed the stale label Jul 13, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 13, 2024
@greenozon
Copy link
Contributor Author

@antonbabenko are you available to review this minor change please?

@antonbabenko
Copy link
Member

Thanks, @greenozon !

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants