Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying configuration / log_configuration block #56

Closed
jfair9 opened this issue Mar 31, 2022 · 7 comments · Fixed by #60
Closed

Add support for specifying configuration / log_configuration block #56

jfair9 opened this issue Mar 31, 2022 · 7 comments · Fixed by #60

Comments

@jfair9
Copy link

jfair9 commented Mar 31, 2022

The aws_ecs_cluster resource provides the ability to specify a logging configuration to ship logs to cloud_watch or a s3_bucket. This feature was introduced back in 3.46.0. Is it possible to get this feature added to the module?

Example:

resource "aws_ecs_cluster" "test" {
  name = "example"

  configuration {
    execute_command_configuration {
      kms_key_id = aws_kms_key.example.arn
      logging    = "OVERRIDE"

      log_configuration {
        cloud_watch_encryption_enabled = true
        cloud_watch_log_group_name     = aws_cloudwatch_log_group.example.name
      }
    }
  }
}
@antonbabenko
Copy link
Member

PR is welcome.

@mrr4cc00n mrr4cc00n mentioned this issue Apr 17, 2022
@mrr4cc00n
Copy link

Hello over there I ran into this same scenario and it would be nice to have it up and running since is part of some security requirements I need to full fill. Here is the PR to add the functionality.

@mrr4cc00n
Copy link

Hello any word on this? @antonbabenko

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this as completed Jun 5, 2022
@antonbabenko
Copy link
Member

This issue has been resolved in version 4.0.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants