Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate half_sat > 0 #2

Open
tomsaleeba opened this issue Sep 16, 2020 · 0 comments
Open

Validate half_sat > 0 #2

tomsaleeba opened this issue Sep 16, 2020 · 0 comments

Comments

@tomsaleeba
Copy link
Collaborator

tomsaleeba commented Sep 16, 2020

migrated from JIRA

Steps:
-set half_sat == 0
-run the model

Expected:
Either the run works or we receive a message saying we can't use that value.

Actual:
The web server gives a 500 and the reason behind the scenes is a divide by 0 error.
We should probably add validation to all values to keep them in the 0...1 range.

/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1267: RuntimeWarning: invalid value encountered in divide
  pat_array[valid_mask]))
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
  return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
  return umr_maximum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1267: RuntimeWarning: invalid value encountered in divide
  pat_array[valid_mask]))
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
  return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
  return umr_maximum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1267: RuntimeWarning: invalid value encountered in divide
  pat_array[valid_mask]))
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
  return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
  return umr_maximum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1293: RuntimeWarning: invalid value encountered in greater
  min_mask = valid_mask & (result > 1.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1320: RuntimeWarning: invalid value encountered in less
  max_mask = valid_mask & (result < 0.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1293: RuntimeWarning: invalid value encountered in greater
  min_mask = valid_mask & (result > 1.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1320: RuntimeWarning: invalid value encountered in less
  max_mask = valid_mask & (result < 0.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1267: RuntimeWarning: invalid value encountered in divide
  pat_array[valid_mask]))
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
  return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
  return umr_maximum(a, axis, None, out, keepdims)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1293: RuntimeWarning: invalid value encountered in greater
  min_mask = valid_mask & (result > 1.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1320: RuntimeWarning: invalid value encountered in less
  max_mask = valid_mask & (result < 0.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1293: RuntimeWarning: invalid value encountered in greater
  min_mask = valid_mask & (result > 1.0)
/usr/local/lib/python2.7/dist-packages/natcap/invest/pollination.py:1320: RuntimeWarning: invalid value encountered in less
  max_mask = valid_mask & (result < 0.0)
DEBUG:natcap_wrapper:execution time 3754ms
@tomsaleeba tomsaleeba changed the title Validate half_sat > Validate half_sat > 0 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant