Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing weighted incorrectly #4481

Closed
shurickdaryin opened this issue Dec 15, 2020 · 3 comments
Closed

Smoothing weighted incorrectly #4481

shurickdaryin opened this issue Dec 15, 2020 · 3 comments

Comments

@shurickdaryin
Copy link

When smoothing a scalar plot, apparently a higher weight is given to the first point. This means that, if there is steep change in the beginning of the graph, the smoothed line will be significantly off the unsmoothed data, and will only slowly move in that direction:

image

One possible way to fix that would be to also smooth the point count (the same way the values are smoothed) and divide by that. There are of course many other alternative approaches.

@nfelt
Copy link
Contributor

nfelt commented Dec 18, 2020

Thanks for bringing this up - we realize the smoothing algorithm is pretty imperfect, despite being the product of several earlier iterations (see #610 for some of this history). There are a few open issues that might already cover the issue you describe, in particular #1127 seems like probably an even simpler case that we don't really handle right (due to biasing too much on the initial value). So if that seems to fairly capture the issue to you, we can mark this as a duplicate.

@shurickdaryin
Copy link
Author

Yes, #1127 seems to refer to the same problem so this bug is probably a duplicate.

@rmothukuru
Copy link

@shurickdaryin,
Closing this issue as it is already being tracked in #1127. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants