-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAILED: Build did NOT complete successfully #1434
Comments
@sihagmnis36 Can you build other tensorboard artifacts outside of that specific What-If Tool demo? For example, do you get the same error if you "bazel build tensorboard" from repository's top-level directory? |
@jameswex I tried that and it gave the same error as before. Here's the complete error.
|
Do you have |
Yes, |
I've hit this also. I've tried to incorporate many additional flags that I've found across various bazel issues:
bazelbuild/bazel#7101 Thus far, I have had no luck getting bazel (v0.26.1) to respect our path to python. Is this better considered a bazel issue? PS: this is in an attempt to build Tensorboard 2.0 with Tensorflow 2.0 on linux-64. The recipe is here, on our 2.0 branch: https://github.com/AnacondaRecipes/tensorflow_recipes/tree/2.0/tensorboard We have tensorflow-base and bazel 0.26.1 packages available on our c3i_test2 conda channel. To reproduce our build, you can run this command from the tensorflow_recipes directory:
|
Are you sure that you’re generating the TensorBoard builds fine for me using the Python in my virtualenv using |
That certainly was a problem! I'm embarrassed. Unfortunately, thing are still not working.
the error:
when you say "using the Python in my virtualenv" - how are you sure that bazel is using it? My linux vm has no "python" in /usr/bin - only in conda environments. I have python3 and friends in /usr/bin. I suspect that your system might be silently using the /usr/bin/python executable without you knowing. Is there a way to debug bazel to show this kind of info? Like show the output of "echo PATH" inside the sandbox? |
sigh - I must have missed saving a file between runs. It appears to work now. Many thanks for your time and attention. EDIT: nope, I had symlinked /usr/bin/python3 to /usr/bin/python. Removing that symlink gets me back to the failure. I'm pretty convinced that Bazel is ignoring my many attempts to redirect PATH stuff. |
Yep, you’re right. One way to confirm this is to replace the problematic diff --git a/tensorboard/scripts/BUILD b/tensorboard/scripts/BUILD
index e006dfa8..e71b812b 100644
--- a/tensorboard/scripts/BUILD
+++ b/tensorboard/scripts/BUILD
@@ -20,7 +20,5 @@ py_binary(
-py_binary(
+sh_binary(
name = "execrooter",
- srcs = ["execrooter.py"],
- srcs_version = "PY2AND3",
- visibility = ["//visibility:public"],
+ srcs = ["execrooter.sh"],
) …whose source performs your desired introspection: # tensorboard/scripts/execrooter.sh
printf 'in execrooter.sh\n'
printf 'my PATH: < %s >\n' "$PATH"
exit 77 Then, just re-run the build. Copying your rc:
On my machine, this prints:
even though that is not the It’s not obvious to me why this would be the case. This could be an py_binary(
name = "my_tool",
srcs = ["my_tool.py"],
)
genrule(
name = "gen_my_tool_py",
outs = ["my_tool.py"],
cmd = "echo 'import os; print(\"exe: %s\" % sys.executable)' >$@",
)
genrule(
name = "use_my_tool",
outs = ["out.txt"],
tools = [":my_tool"],
cmd = "$(execpath :my_tool) >$@",
) …then We can look into this, but probably not in the next week or two; we’re Long shot: does adding |
@wchargin thanks for the helpful leads. I will try your suggestions and let you know. There is no rush on our end. Using the hack with the system python symlink is adequate to create packages, and the output isn't sensitive to which python was used at build time. This said, we generally spend a lot of time battling bazel's idea of hermetic builds, since conda-build is also a tool for hermetic builds (which bazel runs within), and we need conda-build's notion of reality to hold in bazel. Thank you for your time in helping us keep that working. |
@sihagmnis36 Closing this issue since it's resolved. Please reopen if you'd like to work on this further. |
While building the what-if-tool using bazel as per the README file, I get following error:
Working directory is
~/notebooks/tensorboard/tensorboard/plugins/interactive_inference
and command to build bazel is
bazel run --python_path=/opt/conda/bin/python tf_interactive_inference_dashboard/demo:agedemoserver
. I have tried it without giving a python path as well but same error.The text was updated successfully, but these errors were encountered: