diff --git a/tensorboard/webapp/widgets/range_input/range_input_component.ng.html b/tensorboard/webapp/widgets/range_input/range_input_component.ng.html index d785ba38e6..6faabae832 100644 --- a/tensorboard/webapp/widgets/range_input/range_input_component.ng.html +++ b/tensorboard/webapp/widgets/range_input/range_input_component.ng.html @@ -32,12 +32,12 @@ diff --git a/tensorboard/webapp/widgets/range_input/range_input_component.ts b/tensorboard/webapp/widgets/range_input/range_input_component.ts index ef421345d1..be2b4ae203 100644 --- a/tensorboard/webapp/widgets/range_input/range_input_component.ts +++ b/tensorboard/webapp/widgets/range_input/range_input_component.ts @@ -113,18 +113,12 @@ export class RangeInputComponent { readonly Position = Position; - startThumbDrag(value: number) { - this.maybeNotifyNextRangeValues( - [value, this.upperValue], - RangeInputSource.SLIDER - ); - } - - endThumbDrag(value: number) { - this.maybeNotifyNextRangeValues( - [this.lowerValue, value], - RangeInputSource.SLIDER - ); + thumbDrag() { + this.rangeValuesChanged.emit({ + lowerValue: this.lowerValue, + upperValue: this.upperValue, + source: RangeInputSource.SLIDER, + }); } calculateStepSize() { diff --git a/tensorboard/webapp/widgets/range_input/range_input_test.ts b/tensorboard/webapp/widgets/range_input/range_input_test.ts index c76370f74f..80be84962e 100644 --- a/tensorboard/webapp/widgets/range_input/range_input_test.ts +++ b/tensorboard/webapp/widgets/range_input/range_input_test.ts @@ -120,7 +120,7 @@ describe('range input test', () => { ); }); - it('dispatches actions when making range step change', () => { + it('dispatches actions when slider emits valueChange event', () => { const {fixture, onRangeValuesChanged} = createComponent({ lowerValue: -1, upperValue: 1, @@ -130,9 +130,9 @@ describe('range input test', () => { By.css('mat-slider input') )[0]; - sliderThumb.triggerEventHandler('valueChange', -4); + sliderThumb.triggerEventHandler('valueChange'); expect(onRangeValuesChanged).toHaveBeenCalledWith({ - lowerValue: -4, + lowerValue: -1, upperValue: 1, source: RangeInputSource.SLIDER, }); @@ -152,20 +152,6 @@ describe('range input test', () => { '0.5' ); }); - - it('does not trigger change when value does not change', () => { - const {fixture, onRangeValuesChanged} = createComponent({ - lowerValue: -5, - upperValue: 1, - tickCount: 10, - }); - const sliderThumb = fixture.debugElement.queryAll( - By.css('mat-slider input') - )[0]; - - sliderThumb.triggerEventHandler('valueChange', -5); - expect(onRangeValuesChanged).not.toHaveBeenCalled(); - }); }); describe('input control', () => {