From fadaf0fdc0d932e10a304c95c7b736a0bf2bfcbc Mon Sep 17 00:00:00 2001 From: Stephan Lee Date: Thu, 23 Apr 2020 17:53:53 -0700 Subject: [PATCH] scalars: remove unused tooltip column DOM (#3546) When tooltipColumns become shorter after a change, we currently do not remove the DOM. This can lead to an awkward UX where a column in the tooltip never updates and go stale. This change removes the tooltip row column DOM when they are no longer shown. FYI: the tooltip header was properly removed before. --- tensorboard/components/vz_line_chart2/line-chart.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/tensorboard/components/vz_line_chart2/line-chart.ts b/tensorboard/components/vz_line_chart2/line-chart.ts index b7f261bdad..1a09b4ac8b 100644 --- a/tensorboard/components/vz_line_chart2/line-chart.ts +++ b/tensorboard/components/vz_line_chart2/line-chart.ts @@ -704,6 +704,7 @@ namespace vz_line_chart2 { if (col.static) return; self.drawTooltipColumn.call(self, this, col, point); }); + columns.exit().remove(); columns .enter() .append('td')