Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ractor-based sandboxing #184

Closed
cretz opened this issue Jan 8, 2025 · 1 comment
Closed

[Feature Request] Ractor-based sandboxing #184

cretz opened this issue Jan 8, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 8, 2025

Describe the solution you'd like

Decide whether we even want Ractor-based sandboxing, then implement it.

This mostly works today except for Google::Protobuf (see protocolbuffers/protobuf#19321). But we have all these protos and impl in Rust, so it would not be that hard to make a method_missing version of this (which is effectively what the existing Ruby extension does at https://github.com/protocolbuffers/protobuf/tree/main/ruby/ext/google/protobuf_c), just effort and confirming we are ok abandoning the official proto library (which has other benefits such as not clashing with users' protobuf library use).

@cretz cretz added the enhancement New feature or request label Jan 8, 2025
@cretz cretz mentioned this issue Jan 8, 2025
@cretz
Copy link
Member Author

cretz commented Jan 21, 2025

It has been decided that while there are a lot of state-isolation benefits to Ractor-based workflows, since Google::Protobuf doesn't support them and since they are experimental, it is not worth the effort to require them today. We can revisit when ecosystem support improves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant