Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support constructing JSONProtoPayloadConverter with google.protobuf.json_format.Parse options #315

Closed
cretz opened this issue Apr 28, 2023 · 1 comment · Fixed by william-almy-skydio/sdk-python#1 or #365
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Apr 28, 2023

Describe the solution you'd like

People may want to ignore unknown fields and right now they have to remake the class themselves. Make it easier to set the parse options if they wanted to construct this converter w/ different options. Can accept all options or at least ignore unknown fields.

@cretz cretz added the enhancement New feature or request label Apr 28, 2023
@elliot-graebert-skydio
Copy link

This would be hugely helpful. Right now we are heading down the path of doing a custom payload converter because we can't just directly set the option for ignore unknown fields.

Really, what we want is compatibility with the https://pkg.go.dev/go.temporal.io/sdk/converter#ProtoJSONPayloadConverterOptions options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants