Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Latency Check doesn't retry on request failure #89

Closed
1 task done
lvlcn-t opened this issue Jan 25, 2024 · 0 comments · Fixed by #90
Closed
1 task done

Bug: Latency Check doesn't retry on request failure #89

lvlcn-t opened this issue Jan 25, 2024 · 0 comments · Fixed by #90
Assignees
Labels
area/checks Issues/PRs related to Checks bug Something isn't working

Comments

@lvlcn-t
Copy link
Collaborator

lvlcn-t commented Jan 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently the latency check doesn't use its retry mechanism because no error is returned.

Expected Behavior

The retry mechanism is triggered if the request fails.

Steps To Reproduce

  1. Startup the sparrow
  2. Set one of the latency targets to an invalid url
  3. Look at the logs

Relevant logs and/or screenshots, environment information, etc.

$ go run main.go run --config .tmp/start-config.yaml 
Using config file: .tmp/start-config.yaml
{"time":"2024-01-25T14:56:22.596885375+01:00","level":"INFO","source":{"function":"github.com/caas-team/sparrow/cmd.NewCmdRun.run.func1","file":"/home/installadm/dev/github/sparrow/cmd/run.go","line":82},"msg":"Running sparrow"}
{"time":"2024-01-25T14:56:22.597003935+01:00","level":"INFO","source":{"function":"github.com/caas-team/sparrow/pkg/sparrow.(*Sparrow).api.func1","file":"/home/installadm/dev/github/sparrow/pkg/sparrow/api.go","line":81},"msg":"Serving Api","addr":":8080"}
{"time":"2024-01-25T14:56:22.596999388+01:00","level":"INFO","source":{"function":"github.com/caas-team/sparrow/pkg/sparrow/targets.(*gitlabTargetManager).Reconcile","file":"/home/installadm/dev/github/sparrow/pkg/sparrow/targets/gitlab.go","line":80},"msg":"Starting global gitlabTargetManager reconciler"}
{"time":"2024-01-25T14:56:22.5971122+01:00","level":"INFO","source":{"function":"github.com/caas-team/sparrow/pkg/config.(*FileLoader).Run","file":"/home/installadm/dev/github/sparrow/pkg/config/file.go","line":48},"msg":"Reading config from file","file":"./.tmp/run-config.yaml"}
{"time":"2024-01-25T14:56:22.597416945+01:00","level":"WARN","source":{"function":"github.com/caas-team/sparrow/pkg/sparrow.(*Sparrow).registerCheck","file":"/home/installadm/dev/github/sparrow/pkg/sparrow/run.go","line":232},"msg":"Check is not registered","name":"health"}
{"time":"2024-01-25T14:56:22.59755689+01:00","level":"WARN","source":{"function":"github.com/caas-team/sparrow/pkg/sparrow.(*Sparrow).registerCheck","file":"/home/installadm/dev/github/sparrow/pkg/sparrow/run.go","line":232},"msg":"Check is not registered","name":"dns"}
{"time":"2024-01-25T14:56:22.597578372+01:00","level":"INFO","source":{"function":"github.com/caas-team/sparrow/pkg/checks/latency.(*Latency).Run","file":"/home/installadm/dev/github/sparrow/pkg/checks/latency/latency.go","line":91},"msg":"Starting latency check","interval":"20s"}
{"time":"2024-01-25T14:56:42.612641142+01:00","level":"ERROR","source":{"function":"github.com/caas-team/sparrow/pkg/checks/latency.getLatency","file":"/home/installadm/dev/github/sparrow/pkg/checks/latency/latency.go","line":284},"msg":"Error while checking latency","url":"xhttps://example.com","error":"Get \"xhttps://example.com\": unsupported protocol scheme \"xhttps\""}

Who can address the issue?

No response

Anything else?

No response

@lvlcn-t lvlcn-t added bug Something isn't working area/checks Issues/PRs related to Checks labels Jan 25, 2024
@lvlcn-t lvlcn-t self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/checks Issues/PRs related to Checks bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant