Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove any typed Configuration #72

Closed
1 task done
puffitos opened this issue Jan 16, 2024 · 1 comment · Fixed by #93
Closed
1 task done

Refactor: remove any typed Configuration #72

puffitos opened this issue Jan 16, 2024 · 1 comment · Fixed by #93
Assignees
Labels
area/checks Issues/PRs related to Checks refactoring Refactoring of existing code request Indicates a feature request

Comments

@puffitos
Copy link
Collaborator

Is there an existing feature request for this?

  • I have searched the existing issues

Problem Description

We're using any as a type in multiple places to parse the Runtime Configuration of the checks. Since we're not actually using such a feature, we should move away from using the any interface. It complicates our code and makes parsing configuration for Checks prone to errors.

Solution Description

  • Use a RuntimeConfiguration struct to handle the configuration for all checks (as done now) and also use this in all places where the RuntimeConfiguration is touched upon (like the reconciling of the config itself), so we use something that's as close to universal as possible.
  • This object will be passed around and the per-check Config can be used in the needed places, with functions like GetHealthConfig().

Who can address the issue?

No response

Additional Context

No response

@puffitos puffitos added request Indicates a feature request refactoring Refactoring of existing code labels Jan 16, 2024
@puffitos
Copy link
Collaborator Author

I've refactored our current codebase to use some interfaces to handle Runtime Check configuration and remove the wild any usages here. We can come to this implementation or try some other once we've implemented the new Checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/checks Issues/PRs related to Checks refactoring Refactoring of existing code request Indicates a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants