From a39f6b9fd2284a1695d971058904b07db16b0fbf Mon Sep 17 00:00:00 2001
From: lvlcn-t <75443136+lvlcn-t@users.noreply.github.com>
Date: Tue, 12 Mar 2024 10:30:31 +0100
Subject: [PATCH] refactor: test empty config scenario

---
 pkg/config/http_test.go | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/pkg/config/http_test.go b/pkg/config/http_test.go
index a8e93b90..4ab62ce7 100644
--- a/pkg/config/http_test.go
+++ b/pkg/config/http_test.go
@@ -341,10 +341,10 @@ func TestHttpLoader_Run_config_sent_to_channel(t *testing.T) {
 	hl.Shutdown(ctx)
 }
 
-// TestHttpLoader_Run_config_not_sent_to_channel_500 tests if the config is not sent to the channel
+// TestHttpLoader_Run_empty_config_sent_to_channel_500 tests if the config is not sent to the channel
 // when the Run method is called
 // and the remote endpoint returns a non-200 response
-func TestHttpLoader_Run_config_not_sent_to_channel_500(t *testing.T) {
+func TestHttpLoader_Run_empty_config_sent_to_channel_500(t *testing.T) {
 	httpmock.Activate()
 	defer httpmock.DeactivateAndReset()
 
@@ -384,22 +384,18 @@ func TestHttpLoader_Run_config_not_sent_to_channel_500(t *testing.T) {
 		}
 	}()
 
-	// check if the config is sent to the channel
-	select {
-	// make sure you wait for at least an interval
-	case <-time.After(time.Second):
-		t.Log("Config not sent to channel")
-	case c := <-cRuntime:
-		t.Errorf("Config sent to channel: %v", c)
+	cfg := <-cRuntime
+	if cfg != (runtime.Config{}) {
+		t.Errorf("Config sent to channel: %v", cfg)
 	}
 
 	hl.Shutdown(ctx)
 }
 
-// TestHttpLoader_Run_config_not_sent_to_channel_client_error tests if the config is not sent to the channel
+// TestHttpLoader_Run_empty_config_sent_to_channel_client_error tests if the config is not sent to the channel
 // when the Run method is called
 // and the client can't execute the requests
-func TestHttpLoader_Run_config_not_sent_to_channel_client_error(t *testing.T) {
+func TestHttpLoader_Run_empty_config_sent_to_channel_client_error(t *testing.T) {
 	httpmock.Activate()
 	defer httpmock.DeactivateAndReset()
 
@@ -435,13 +431,9 @@ func TestHttpLoader_Run_config_not_sent_to_channel_client_error(t *testing.T) {
 		}
 	}()
 
-	// check if the config is sent to the channel
-	select {
-	// make sure you wait for at least an interval
-	case <-time.After(time.Second):
-		t.Log("Config not sent to channel")
-	case c := <-cRuntime:
-		t.Errorf("Config sent to channel: %v", c)
+	cfg := <-cRuntime
+	if cfg != (runtime.Config{}) {
+		t.Errorf("Config sent to channel: %v", cfg)
 	}
 
 	hl.Shutdown(ctx)