Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventListener spec validation is missing #1269

Closed
savitaashture opened this issue Nov 24, 2021 · 0 comments · Fixed by #1277
Closed

EventListener spec validation is missing #1269

savitaashture opened this issue Nov 24, 2021 · 0 comments · Fixed by #1277
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@savitaashture
Copy link
Contributor

Expected Behavior

  • Creating EventListener should fail if provided spec is empty
  • Its expected that atleast atleast one of the label selector, namespace selector, or triggers (or triggerGroup) is provided

Actual Behavior

  • Creating EventListener is success if provided spec is empty and creates EL pod but that doesn't do any functionality.

Steps to Reproduce the Problem

  1. Create EL with empty spec
  2. Pod creation success
  3. sending request to EL pod fails

Additional Info

  • Kubernetes version:

    Output of kubectl version:

kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3", GitCommit:"c92036820499fedefec0f847e2054d824aea6cd1", GitTreeState:"clean", BuildDate:"2021-10-27T18:35:25Z", GoVersion:"go1.16.9", Compiler:"gc", Platform:"linux/amd64"}  
  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

@savitaashture savitaashture added the kind/bug Categorizes issue or PR as related to a bug. label Nov 24, 2021
@savitaashture savitaashture self-assigned this Nov 24, 2021
@dibyom dibyom added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants