Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream error messages reference shall be used from imports #7466

Closed
JeromeJu opened this issue Dec 7, 2023 · 3 comments · Fixed by #7780
Closed

Upstream error messages reference shall be used from imports #7466

JeromeJu opened this issue Dec 7, 2023 · 3 comments · Fixed by #7780
Assignees
@lunarwhite
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Dec 7, 2023

Context:

OptimisticLockErrorMsg is an error message exported from k8s.io/apiserver/pkg/registry/generic/registry. But the import of the package is blocked as noted at #7464.

This issue tracks that once we have the dependencies bumped successfully with the fix of #7464, we shall reference the const created in pipeline to the upstream constants for consistency and maintainability.

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 7, 2023
@Yongxuanzhang Yongxuanzhang mentioned this issue Dec 8, 2023
Merged
7 tasks
@pritidesai
Copy link
Member

Hey @JeromeJu, we have the dependencies fixed for this issue, is this issue unblocked?

@pritidesai pritidesai added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 25, 2024
@JeromeJu
Copy link
Member Author

@pritidesai yes this is unblocked by #7464.
Thanks for adding the label 🙏

@lunarwhite
Copy link
Contributor

I'd like to help with it.

/assign

@lunarwhite lunarwhite mentioned this issue Mar 20, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunarwhite lunarwhite

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: add notes for why not to import the dependency pkg for OptimisticLockErrorMsg
4 participants
@pritidesai @JeromeJu @tekton-robot @lunarwhite