Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Container termination status when failing TaskRun for Image pull errors #7385

Closed
JeromeJu opened this issue Nov 17, 2023 · 0 comments
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 17, 2023

From #4921 , we introduced the mechanism for failing the TaskRun when any of the step fails with the image pull error: ImagePullBackOff. It also then marks all other steps in the Task as failed with the same reason "TaskRunImagePullFailed". This issue proposes the improvements of the error handling:

  • Mark other steps terminated as a new pod status reason, instead of marking them all by a Taskrun reason, to clarify that it has not been executed: something like CanceledPreviousStepImagePullError
  • We could add specific step, image being pulled to the &corev1.ContainerStateTerminated at failTaskRun.
  • Cleanups on the existing error messages and controller logs.

We shall also explore the extensibility of step/container to examine how we could distinguish TaskRun reason and Step reason more precisely for a better user debug experience. For example, better clarifications of step failures for image pull errors.

/kind bug
/kind feature

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 17, 2023
@JeromeJu JeromeJu changed the title Better reason for Container termination status when failing TaskRun for Image pull errors Better Container termination status when failing TaskRun for Image pull errors Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants