-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation documentation to handle kube object removal #6668
Comments
Shouldn't it be |
yes thanks :) |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/lifecycle frozen |
/assign jgustafsoniii |
When running
|
We could mention here that the install guide is meant for a quickstart with Tekton but not meant for production use. |
@afrittoli I ran some tests starting off with v0.46.0 and then tried replace --force and apply --force to see if runs.tekton.dev would disappear but it never did. This was a suggestion from @pritidesai. I agree that the quick start should mention that its not for production use. What should the upgrade steps be if you are upgrading from an older version? |
@JGustafsonIII, we had discussion this morning in the API WG, the conclusion of this discussion was to add a note in the installation section first bullet:
|
Thank you, I will update the doc and submit a PR. |
I think this can be closed now @JGustafsonIII ? |
@dibyom Yes this can be closed |
Our installation documentation instructs users to use
kubectl apply
. However, if a release of Pipelines removes an object in the config folder,kubectl apply
will not remove this object from clusters that are upgrading their Pipelines version. For example, we removed theRun
CRD, but the CRDruns.tekton.dev
may still be present on clusters that have upgraded (it's still present on the dogfood cluster).We should update our documentation to instruct users to install Pipelines w/
kubectl replace
, or some other option that will remove Tekton config objects that are no longer present. The Tekton operator may need similar changes as well, but this should be tracked separately.Note: It is unclear whether
kubectl apply
will correctly handle changes to the storage version of CRDs.kubectl apply
will update any existing CRD definitions; however, the docs make it a bit unclear how these changes are merged:cc @vdemeester
The text was updated successfully, but these errors were encountered: